dcmtk.git
13 months agoAdded check to make sure: HighBit < BitsAllocated.
Joerg Riesmeier [Sat, 18 Jan 2025 15:30:29 +0000 (16:30 +0100)]
Added check to make sure: HighBit < BitsAllocated.

Forwarded: https://git.dcmtk.org/?p=dcmtk.git;a=commit;h=03e851b0586d05057c3268988e180ffb426b2e03
Bug-Debian: https://bugs.debian.org/1093047
Reviewed-By: Étienne Mollier <emollier@debian.org>
Last-Update: 2025-01-18

Added check to the image preprocessing to make sure that the value of
HighBit is always less than the value of BitsAllocated. Before, this
missing check could lead to memory corruption if an invalid combination
of values was retrieved from a malformed DICOM dataset.

Thanks to Emmanuel Tacheau from the Cisco Talos team
<vulndiscovery@external.cisco.com> for the report, sample file (PoC)
and detailed analysis. See TALOS-2024-2121 and CVE-2024-52333.

Gbp-Pq: Name 0008-CVE-2024-52333.patch

13 months agoFixed issue rendering invalid monochrome image.
Joerg Riesmeier [Sat, 18 Jan 2025 15:30:29 +0000 (16:30 +0100)]
Fixed issue rendering invalid monochrome image.

Forwarded: https://git.dcmtk.org/?p=dcmtk.git;a=commit;h=89a6e399f1e17d08a8bc8cdaa05b2ac9a50cd4f6
Bug-Debian: https://bugs.debian.org/1093043
Reviewed-By: Étienne Mollier <emollier@debian.org>
Last-Update: 2025-01-18

Fixed issue when rendering an invalid monochrome DICOM image where the
number of pixels stored does not match the expected number of pixels.
If the stored number is less than the expected number, the rest of the
pixel matrix for the intermediate representation was always filled with
the value 0. Under certain, very rare conditions, this could result in
memory problems reported by an Address Sanitizer (ASAN). Now, the rest
of the matrix is filled with the smallest possible value for the image.

Thanks to Emmanuel Tacheau from the Cisco Talos team
<vulndiscovery@external.cisco.com> for the original report, the sample
file (PoC) and further details. See TALOS-2024-2122 and CVE-2024-47796.

Gbp-Pq: Name 0007-CVE-2024-47796.patch

13 months agoFixed possible overflows when allocating memory.
Michael Onken [Tue, 20 Feb 2024 09:50:28 +0000 (10:50 +0100)]
Fixed possible overflows when allocating memory.

Thanks to GitHub user "bananabr" (Daniel Berredo) for the report and
suggested patch.

Gbp-Pq: Name 0006-Fixed-possible-overflows-when-allocating-memory.patch

13 months ago[PATCH] Fixed DcmDecimalString unit tests.
Marco Eichelberg [Wed, 13 Mar 2024 22:03:40 +0000 (23:03 +0100)]
[PATCH] Fixed DcmDecimalString unit tests.

Gbp-Pq: Name 0005-Fixed-DcmDecimalString-unit-tests.patch

13 months ago[PATCH] Fixed two segmentation faults.
Marco Eichelberg [Wed, 13 Mar 2024 16:15:58 +0000 (17:15 +0100)]
[PATCH] Fixed two segmentation faults.

Fixed two segmentations faults that could occur while processing an
invalid incoming DIMSE message due to insufficient error handling
causing a de-referenced NULL pointer.

Thanks to Nils Bars <nils.bars@rub.de> for the bug report and sample files.

This closes DCMTK issue #1114.

Gbp-Pq: Name 0004-Fixed-two-segmentation-faults.patch

13 months ago[PATCH] Fixed wrong error handling (previous commit).
Joerg Riesmeier [Mon, 22 Apr 2024 10:11:11 +0000 (12:11 +0200)]
[PATCH] Fixed wrong error handling (previous commit).

Fixed wrong error handling introduced with the previous commit.

Gbp-Pq: Name 0003-Fixed-wrong-error-handling-previous-commit.patch

13 months ago[PATCH] Fixed unchecked typecasts and fixed LUT handling.
Marco Eichelberg [Mon, 15 Apr 2024 10:19:33 +0000 (12:19 +0200)]
[PATCH] Fixed unchecked typecasts and fixed LUT handling.

This commit adds further fixes for unchecked typecasts of DcmItem::search()
results (see description of previous commit). Furthermore, this commit
specifically addresses the handling of look-up tables (LUTs) in module
dcmpstat, where attribute (0028,3006) LUTData may use either US or OW
value representation, and (0028,3002) LUTDescriptor may be either US or SS.
The code should now properly handle all permitted value representations.
LUTData is now always written as OW in order to avoid the 64k size limit
for US in explicit VR encoding.

Thanks to Martin Zeiser from the Cisco Talos team
<vulndiscovery@external.cisco.com> for the bug report (TALOS-2024-1957).

Together with the previous commit, this closes DCMTK issue #1120.

Gbp-Pq: Name 0002-Fixed-unchecked-typecasts-and-fixed-LUT-handling.patch

13 months ago[PATCH] Fixed unchecked typecasts of DcmItem::search results.
Marco Eichelberg [Mon, 15 Apr 2024 10:12:51 +0000 (12:12 +0200)]
[PATCH] Fixed unchecked typecasts of DcmItem::search results.

DcmItem::search() returns a stack of DcmObject pointers as search results.
These pointers in most instances need to be casted to DcmItem, DcmElement
or a subclass of these. In many cases, the type of the object was not
properly checked before the typecast. This could lead to segmentation faults
when invalid DICOM datasets were processed where elements had the wrong
value representation.

Gbp-Pq: Name 0001-Fixed-unchecked-typecasts-of-DcmItem-search-results.patch

13 months ago[PATCH] Fixed issue with delimiters being converted.
Joerg Riesmeier [Wed, 8 Nov 2023 10:38:54 +0000 (11:38 +0100)]
[PATCH] Fixed issue with delimiters being converted.

Fixed issue with delimiter character "\" being converted when converting
a DICOM dataset that uses a Specific Character Set of "ISO 2022 IR 13\ISO
2022 IR 87" to UTF-8. The delimiter "\" was incorrectly converted to the
Yen sign when processing the value of an "LO" data element that contains
multiple values but does not use any escape sequences. This issues has
been fixed now by always treating the delimiters in a special way.

Thanks to Mathieu Malaterre <mathieu.malaterre@gmail.com> for the report
and David Gobbi <david.gobbi@gmail.com> for the analysis and testing.

Gbp-Pq: Name da5370947226783ce3548bf1e5b7112fac70de46.patch

13 months agoRemove version
Mathieu Malaterre [Sat, 18 Jan 2025 15:30:29 +0000 (16:30 +0100)]
Remove version

Forwarded: not-needed
Last-Update: 2023-11-06

Gbp-Pq: Name remove_version.patch

13 months agoDon't add executables to cmake exports
Gert Wollny [Sat, 18 Jan 2025 15:30:29 +0000 (16:30 +0100)]
Don't add executables to cmake exports

Bug-Debian: https://bugs.debian.org/803304
Forwarded: not-needed

CMake exports are used by other packages that compile
and link against dcmtk. Because Debian moves some of
these executables and also dosn't install the test
executables, this import may fail leading to failure
to configure the according package.
===================================================================

Gbp-Pq: Name 07_dont_export_all_executables.patch

13 months agoThe original maintainer Jürgen Salk applied
Jürgen Salk [Sat, 18 Jan 2025 15:30:29 +0000 (16:30 +0100)]
The original maintainer Jürgen Salk applied

Forwarded: not-needed

a set of patches to the original code.  This file contains
changes to C++ code

Gbp-Pq: Name 01_dcmtk_3.6.0-1.patch

13 months agodcmtk (3.6.8-7) unstable; urgency=medium
Étienne Mollier [Sat, 18 Jan 2025 15:30:29 +0000 (16:30 +0100)]
dcmtk (3.6.8-7) unstable; urgency=medium

  * Team upload.
  * 0001-Fixed-unchecked-typecasts-of-DcmItem-search-results.patch.
    Patch refreshed.
  * 0004-Fixed-two-segmentation-faults.patch: unfuzz.
  * 0007-CVE-2024-47796.patch: new.
    This patch addresses CVE-2024-47796. (Closes: #1093043)
  * 0008-CVE-2024-52333.patch: new.
    This patch addresses CVE-2024-52333. (Closes: #1093047)

[dgit import unpatched dcmtk 3.6.8-7]

13 months agoImport dcmtk_3.6.8-7.debian.tar.xz
Étienne Mollier [Sat, 18 Jan 2025 15:30:29 +0000 (16:30 +0100)]
Import dcmtk_3.6.8-7.debian.tar.xz

[dgit import tarball dcmtk 3.6.8-7 dcmtk_3.6.8-7.debian.tar.xz]

20 months agoImport dcmtk_3.6.8.orig.tar.gz
Mathieu Malaterre [Mon, 24 Jun 2024 18:43:54 +0000 (20:43 +0200)]
Import dcmtk_3.6.8.orig.tar.gz

[dgit import orig dcmtk_3.6.8.orig.tar.gz]